commit a7aa2bb8f86f9891bba9d05544e2b9796b2da864
author Brian Smith <brian@briansmith.org> Fri Mar 25 14:22:40 2016 -1000
committer David Benjamin <davidben@google.com> Wed Apr 20 22:53:46 2016 +0000
tree cab8f59cfaf3ddc3f4274a51f5fa266ca197f7a4
parent d860b7b1cdefa22b2d42074aa5c8ce2a8ec1da5c

Avoid a multiplication in |ecp_nistz256_get_affine| when |x| is NULL.

This is purely hypothetical, as in real life nobody cares about the
|y| component without also caring about the |x| component, but it
clarifies the code and makes a future change clearer.

Change-Id: Icaa4de83c87b82a8e68cd2942779a06e5db300c3
Reviewed-on: https://boringssl-review.googlesource.com/7588
Reviewed-by: David Benjamin <davidben@google.com>

crypto/ec/p256-x86_64.c

diff --git a/crypto/ec/p256-x86_64.c b/crypto/ec/p256-x86_64.c
index 17ab91b..b11e37f 100644
--- a/crypto/ec/p256-x86_64.c
+++ b/crypto/ec/p256-x86_64.c
@@ -502,8 +502,6 @@
                                    BIGNUM *x, BIGNUM *y, BN_CTX *ctx) {
   BN_ULONG z_inv2[P256_LIMBS];
   BN_ULONG z_inv3[P256_LIMBS];
-  BN_ULONG x_aff[P256_LIMBS];
-  BN_ULONG y_aff[P256_LIMBS];
   BN_ULONG point_x[P256_LIMBS], point_y[P256_LIMBS], point_z[P256_LIMBS];
 
   if (EC_POINT_is_at_infinity(group, point)) {
@@ -520,9 +518,11 @@
 
   ecp_nistz256_mod_inverse(z_inv3, point_z);
   ecp_nistz256_sqr_mont(z_inv2, z_inv3);
-  ecp_nistz256_mul_mont(x_aff, z_inv2, point_x);
 
   if (x != NULL) {
+    BN_ULONG x_aff[P256_LIMBS];
+
+    ecp_nistz256_mul_mont(x_aff, z_inv2, point_x);
     if (bn_wexpand(x, P256_LIMBS) == NULL) {
       OPENSSL_PUT_ERROR(EC, ERR_R_MALLOC_FAILURE);
       return 0;
@@ -534,6 +534,8 @@
   }
 
   if (y != NULL) {
+    BN_ULONG y_aff[P256_LIMBS];
+
     ecp_nistz256_mul_mont(z_inv3, z_inv3, z_inv2);
     ecp_nistz256_mul_mont(y_aff, z_inv3, point_y);
     if (bn_wexpand(y, P256_LIMBS) == NULL) {