Google Git
Sign in
boringssl / boringssl.git / a792f8804773f9c6c8fa55a8d9a502d56bd79b2b
commita792f8804773f9c6c8fa55a8d9a502d56bd79b2b[log] [tgz]
authorDavid Benjamin <davidben@google.com>Mon Mar 11 15:59:01 2024 -0400
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 11 21:49:17 2024 +0000
treeb4778df848e1fadf463dfd92f488b166d49bd664
parentddb002fc522a7ab7939a892862febcccd62f23e4 [diff]
Fix a number of cases overwriting certificates, keys, etc. with SSL_CREDENTIAL

Field-by-field setters make the worst APIs. This fixes the following:

- Calling SSL_CTX_set_chain_and_key twice should override the old one
  (Regression from SSL_CREDENTIAL.)

- Various APIs forgot to clear the old chain before appending new ones.
  (Regression from SSL_CREDENTIAL.)

- Switching between a custom private key and a concrete one should not
  leave the old one lying around. (I think this was always broken.)

Add tests for all of these cases.

Change-Id: Ief7b3aecf2ada3b123d79d4eddf464c65d5f7d0d
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66907
Commit-Queue: David Benjamin <davidben@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
Commit-Queue: Bob Beck <bbe@google.com>
6 files changed
tree: b4778df848e1fadf463dfd92f488b166d49bd664
  1. .github/
  2. cmake/
  3. crypto/
  4. decrepit/
  5. fuzz/
  6. include/
  7. pki/
  8. rust/
  9. ssl/
  10. third_party/
  11. tool/
  12. util/
  13. .clang-format
  14. .gitignore
  15. API-CONVENTIONS.md
  16. BREAKING-CHANGES.md
  17. BUILDING.md
  18. CMakeLists.txt
  19. codereview.settings
  20. CONTRIBUTING.md
  21. FUZZING.md
  22. go.mod
  23. go.sum
  24. INCORPORATING.md
  25. LICENSE
  26. PORTING.md
  27. README.md
  28. SANDBOXING.md
  29. sources.cmake
  30. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

There are other files in this directory which might be helpful: