commit a4f8755f8e66b77ca2230f376bc5d5d54b28544e
author David Benjamin <davidben@google.com> Fri Jul 14 17:27:07 2023 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 14 22:19:25 2023 +0000
tree 0f57c86cb07d0a11debc609c17bbf3e1ca017506
parent 2a900c16a4110e9304e4a2face2d287ac6c7975a

Fix error handling in bssl_shim socket object

We'd leak the socket if Connect failed in the middle. (This doesn't
especially matter. The test process would just exit anyway.)

Change-Id: I8e1f252781810b1d8ef3c41bd707dfebb0371e60
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61665
Reviewed-by: Bob Beck <bbe@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: Bob Beck <bbe@google.com>

ssl/test/bssl_shim.cc

diff --git a/ssl/test/bssl_shim.cc b/ssl/test/bssl_shim.cc
index 19b838a..508b192 100644
--- a/ssl/test/bssl_shim.cc
+++ b/ssl/test/bssl_shim.cc
@@ -123,8 +123,8 @@
             break;
           }
         }
-        closesocket(sock_);
       }
+      closesocket(sock_);
     }
 
     drain_on_close_ = false;