| commit | a028a5e01f2cd627e31f3d3dbdd8fe1f707734b4 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Feb 06 12:22:07 2023 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 06 18:07:30 2023 +0000 |
| tree | 0b4630a897c4842bf7da273540f50ae1a451495c | |
| parent | eb0b7e4df6eb5a082c2b977784f4270b55c58361 [diff] |
Fix leak in set_dist_point_name error handling. The temporary X509_NAME wasn't destroyed if the section didn't exist. Also document the weird 0 vs -1 convention (see callers), and revise the NULL check added in https://boringssl-review.googlesource.com/c/boringssl/+/56705. It doesn't make a difference, but we should only apply the NULL check after we've looked at the name, and return -1 because, after the name is checked, it's a known syntax error. Also fix a couple of comments that were wrong. It's that the RDNSequence we take from X509_NAME must have one RDN, not that there's one RDNSequence. (This is a consequence of X509_NAME's somewhat odd in-memory representation.) Bug: oss-fuzz:55700 Change-Id: I5745752bfa82802d361803868f962b2b0fa4bd32 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56929 Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: Bob Beck <bbe@google.com> Reviewed-by: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: