tree 7d707e70a6089c213f522f37065de3ea81155ead
parent 4cb8494d25e5c898bb4f0309de9d5df23dfcdfbf
author Brian Smith <brian@briansmith.org> 1470198078 -1000
committer David Benjamin <davidben@google.com> 1482001879 +0000

Remove the non-no_branch branch of BN_div.

Simplify the code, and in particular make |BN_div|, |BN_mod|, and
|BN_nnmod| insensitive to |BN_FLG_CONSTTIME|. This improves the
effectiveness of testing by reducing the number of branches that are
likely to go untested or less tested.

There is no performance-sensitive code that uses BN_div but doesn't
already use BN_FLG_CONSTTIME except RSA signature verification and
EC_GROUP creation. RSA signature verification, ECDH, and ECDSA
performance aren't significantly different with this change.

Change-Id: Ie34c4ce925b939150529400cc60e1f414c7676cd
Reviewed-on: https://boringssl-review.googlesource.com/9105
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>