Remove SSL 3.0 implementation. Update-Note: SSL_CTX_set_min_proto_version(SSL3_VERSION) now fails. SSL_OP_NO_SSLv3 is now zero. Internal SSL3-specific "AEAD"s are gone. Change-Id: I34edb160be40a5eea3e2e0fdea562c6e2adda229 Reviewed-on: https://boringssl-review.googlesource.com/29444 Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Reviewed-by: Adam Langley <agl@google.com>
diff --git a/ssl/ssl_lib.cc b/ssl/ssl_lib.cc index 8f969c5..9796f0c 100644 --- a/ssl/ssl_lib.cc +++ b/ssl/ssl_lib.cc
@@ -464,10 +464,7 @@ return false; } - // We do not accept at SSL 3.0. SSL 3.0 will be removed entirely in the future - // and requires retaining more data for renegotiation_info. - uint16_t version = ssl_protocol_version(ssl); - if (version == SSL3_VERSION || version >= TLS1_3_VERSION) { + if (ssl_protocol_version(ssl) >= TLS1_3_VERSION) { return false; } @@ -1490,9 +1487,8 @@ *out_len = 0; OPENSSL_memset(out, 0, max_out); - // tls-unique is not defined for SSL 3.0 or TLS 1.3. + // tls-unique is not defined for TLS 1.3. if (!ssl->s3->initial_handshake_complete || - ssl_protocol_version(ssl) < TLS1_VERSION || ssl_protocol_version(ssl) >= TLS1_3_VERSION) { return 0; } @@ -1644,7 +1640,6 @@ size_t SSL_get_finished(const SSL *ssl, void *buf, size_t count) { if (!ssl->s3->initial_handshake_complete || - ssl_protocol_version(ssl) < TLS1_VERSION || ssl_protocol_version(ssl) >= TLS1_3_VERSION) { return 0; } @@ -1660,7 +1655,6 @@ size_t SSL_get_peer_finished(const SSL *ssl, void *buf, size_t count) { if (!ssl->s3->initial_handshake_complete || - ssl_protocol_version(ssl) < TLS1_VERSION || ssl_protocol_version(ssl) >= TLS1_3_VERSION) { return 0; }