Don't use bugs to test normal cipher/version pairs. Otherwise if the client's ClientHello logic is messed up and ServerHello is fine, we won't notice. Change-Id: I7f983cca45f7da1113ad4a72de1f991115e1b29a Reviewed-on: https://boringssl-review.googlesource.com/8511 Reviewed-by: David Benjamin <davidben@google.com>
diff --git a/ssl/test/runner/runner.go b/ssl/test/runner/runner.go index 3b95b2c..909a0e8 100644 --- a/ssl/test/runner/runner.go +++ b/ssl/test/runner/runner.go
@@ -2355,8 +2355,8 @@ PreSharedKey: []byte(psk), PreSharedKeyIdentity: pskIdentity, Bugs: ProtocolBugs{ - EnableAllCiphers: true, - IgnorePeerCipherPreferences: true, + EnableAllCiphers: shouldServerFail, + IgnorePeerCipherPreferences: shouldServerFail, }, }, certFile: certFile, @@ -2379,8 +2379,8 @@ PreSharedKey: []byte(psk), PreSharedKeyIdentity: pskIdentity, Bugs: ProtocolBugs{ - EnableAllCiphers: true, - IgnorePeerCipherPreferences: true, + EnableAllCiphers: shouldClientFail, + IgnorePeerCipherPreferences: shouldClientFail, }, }, flags: flags,