commit 9498e74a92ce6289af2a9dddb14b75445de87d9c
author Adam Langley <agl@google.com> Mon Jul 18 10:17:16 2016 -0700
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Mon Aug 01 18:11:39 2016 +0000
tree f2ce855627ae6c12bd79c2f7c05e90367d60134a
parent 0d1b0961f9b8ef720cd96ae0a7ac3edcbbf538e5

Don't have the default value of |verify_result| be X509_V_OK.

It seems much safer for the default value of |verify_result| to be an
error value.

Change-Id: I372ec19c41d77516ed12d0169969994f7d23ed70
Reviewed-on: https://boringssl-review.googlesource.com/9063
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

ssl/ssl_session.c

diff --git a/ssl/ssl_session.c b/ssl/ssl_session.c
index 0a9ccba..006e635 100644
--- a/ssl/ssl_session.c
+++ b/ssl/ssl_session.c
@@ -167,7 +167,7 @@
   }
   memset(session, 0, sizeof(SSL_SESSION));
 
-  session->verify_result = 1; /* avoid 0 (= X509_V_OK) just in case */
+  session->verify_result = X509_V_ERR_INVALID_CALL;
   session->references = 1;
   session->timeout = SSL_DEFAULT_SESSION_TIMEOUT;
   session->time = (unsigned long)time(NULL);
@@ -457,7 +457,7 @@
 
   /* The session is marked not resumable until it is completely filled in. */
   session->not_resumable = 1;
-  session->verify_result = X509_V_OK;
+  session->verify_result = X509_V_ERR_INVALID_CALL;
 
   SSL_SESSION_free(ssl->s3->new_session);
   ssl->s3->new_session = session;