Fix BN_kronecker on unreachable BN_rshift error.
The error value is -2, but at this point ret has already been set to
some running answer and must be reset to -2.
(This is unreachable. BN_rshift only fails on caller or malloc error,
and it doesn't need to malloc when running in-place.)
Change-Id: I33930da84b00d1906bdee9d09b9504ea8121fac4
Reviewed-on: https://boringssl-review.googlesource.com/12681
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
diff --git a/crypto/bn/kronecker.c b/crypto/bn/kronecker.c
index 23ef79a..2089851 100644
--- a/crypto/bn/kronecker.c
+++ b/crypto/bn/kronecker.c
@@ -144,6 +144,7 @@
i++;
}
if (!BN_rshift(A, A, i)) {
+ ret = -2;
goto end;
}
if (i & 1) {
