)]}'
{
  "commit": "906bbef001677c3bbec23143404c854948b1b4d1",
  "tree": "700e9707cc1401daa81041351242a4404ea6136a",
  "parents": [
    "62f662dbeb3b25b82a33aeab559477cd2d47b6e1"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sat Dec 14 02:04:44 2019 -0500"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Mon Dec 16 20:17:51 2019 +0000"
  },
  "message": "Handle \"acceptable\" Wycheproof inputs unambiguously.\n\nThis CL updates the JSON conversion to preserve the flags. A\nWycheproofResult now captures both \"result\" and \"flags\". An \"acceptable\"\ntest case\u0027s validity is determined by its flags. By default, we consider\nan \"acceptable\" case as invalid, but a test driver may mark some of them\nas valid by listing the flags as a parameter.\n\nPreviously, some Wycheproof tests (I think it was x25519_tests.txt?) did\nnot contain enough information to resolve this unambiguously. This has\nsince been fixed.\n\nThis also makes the converted files smaller because we no longer expand the\nflags into comments.\n\nChange-Id: I2ca02d7f1b95f250409e8b23c4ad7bb595d77fdf\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/39188\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "520ad7255a74d287e38267f353c0756a5dec49f4",
      "old_mode": 33188,
      "old_path": "crypto/cipher_extra/aead_test.cc",
      "new_id": "bb3db9e506407fbf7e1767a3236e2ac09b51427d",
      "new_mode": 33188,
      "new_path": "crypto/cipher_extra/aead_test.cc"
    },
    {
      "type": "modify",
      "old_id": "0a96bf39fed641cd9dbeacc865c68f4cd678aa13",
      "old_mode": 33188,
      "old_path": "crypto/cipher_extra/cipher_test.cc",
      "new_id": "a28e6e3d280fc1e0455cef62033aba41c001a77d",
      "new_mode": 33188,
      "new_path": "crypto/cipher_extra/cipher_test.cc"
    },
    {
      "type": "modify",
      "old_id": "bd6651d4f0ec7b277edb8f8e987b9b8642887a4e",
      "old_mode": 33188,
      "old_path": "crypto/cmac/cmac_test.cc",
      "new_id": "e8a220aced4c6a0b1a904ab71a4500be3ce33c28",
      "new_mode": 33188,
      "new_path": "crypto/cmac/cmac_test.cc"
    },
    {
      "type": "modify",
      "old_id": "9578dd03d5f4ecc282ce60c0b3bca6f0b869fbbe",
      "old_mode": 33188,
      "old_path": "crypto/curve25519/x25519_test.cc",
      "new_id": "1bf398f992a2fcaadf8ff4b3ba04107239d90021",
      "new_mode": 33188,
      "new_path": "crypto/curve25519/x25519_test.cc"
    },
    {
      "type": "modify",
      "old_id": "52e49f1db222b4e7dc4e96c57e95cfb0fbbf0afd",
      "old_mode": 33188,
      "old_path": "crypto/ecdh_extra/ecdh_test.cc",
      "new_id": "4b88754fd304636f2c91a5a8384c7950e50921f3",
      "new_mode": 33188,
      "new_path": "crypto/ecdh_extra/ecdh_test.cc"
    },
    {
      "type": "modify",
      "old_id": "4846fbc072530c98fb67fdc735d6f5f7f7a3e5be",
      "old_mode": 33188,
      "old_path": "crypto/evp/evp_test.cc",
      "new_id": "9932982fe8fb5703d2f6844962978c36b6876039",
      "new_mode": 33188,
      "new_path": "crypto/evp/evp_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5061e0130cf3e7b06c89317ee7afb2eec8dd150d",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/aes/aes_test.cc",
      "new_id": "4c913d3ca687cc52425d3a38542016afb34e0d99",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/aes/aes_test.cc"
    },
    {
      "type": "modify",
      "old_id": "504e9279204ae7c0266aaa31ec90189db9c6ad7d",
      "old_mode": 33188,
      "old_path": "crypto/hkdf/hkdf_test.cc",
      "new_id": "793506ffa405749a30fbc693dd4c2da8e557b60a",
      "new_mode": 33188,
      "new_path": "crypto/hkdf/hkdf_test.cc"
    },
    {
      "type": "modify",
      "old_id": "b96abbd348dfd81e56c4e5ef06a853a2e4c0efe8",
      "old_mode": 33188,
      "old_path": "crypto/hmac_extra/hmac_test.cc",
      "new_id": "c2d6199390f1617468eb28b95e1b6e63fa961476",
      "new_mode": 33188,
      "new_path": "crypto/hmac_extra/hmac_test.cc"
    },
    {
      "type": "modify",
      "old_id": "8f7dfeb0661d8ad9661380eb23955116fb31c641",
      "old_mode": 33188,
      "old_path": "crypto/test/wycheproof_util.cc",
      "new_id": "cd870ddf17d87cc62aecb8ff2104e2238b1c9b8b",
      "new_mode": 33188,
      "new_path": "crypto/test/wycheproof_util.cc"
    },
    {
      "type": "modify",
      "old_id": "4d8a14c87727b5a7cf00211cf3fbd6f2f45729a2",
      "old_mode": 33188,
      "old_path": "crypto/test/wycheproof_util.h",
      "new_id": "67e0ed3fe97f59e2095a90b490b332d74f290e81",
      "new_mode": 33188,
      "new_path": "crypto/test/wycheproof_util.h"
    },
    {
      "type": "modify",
      "old_id": "f15837c3b7842a152135fd143d89ce6e5929d566",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/aes_cbc_pkcs5_test.txt",
      "new_id": "0a259b833ee05a2b3c694dfa3daa670714e5dc65",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/aes_cbc_pkcs5_test.txt"
    },
    {
      "type": "modify",
      "old_id": "3a4b55642c92a6c1403fe536d2c4b8fa90ccf412",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/aes_gcm_siv_test.txt",
      "new_id": "9f0ba237b1895fdabb1f044792011675961ec1d4",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/aes_gcm_siv_test.txt"
    },
    {
      "type": "modify",
      "old_id": "e8799211193a5b26b13f6ba87c6542b6e53ebf66",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/aes_gcm_test.txt",
      "new_id": "4600340637c27639fd86bdb0ad2d1dc236a10fc1",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/aes_gcm_test.txt"
    },
    {
      "type": "modify",
      "old_id": "3805f122bdb7259e66aa458dedb0195929ab0546",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/dsa_test.txt",
      "new_id": "14ad49096ff225b221cb0aae1cb69c16fedc4867",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/dsa_test.txt"
    },
    {
      "type": "modify",
      "old_id": "9354e300c7ef637657c11b90f44ddeac232cbbb0",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdh_secp224r1_test.txt",
      "new_id": "9e339ae2947e52bfa97751ae3efa83c4223941f9",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdh_secp224r1_test.txt"
    },
    {
      "type": "modify",
      "old_id": "fe35b506631075ba4e961fa7197d41928f721e90",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdh_secp256r1_test.txt",
      "new_id": "f4a348fed070b0a8d8a9a1133f2636b3454e2dd2",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdh_secp256r1_test.txt"
    },
    {
      "type": "modify",
      "old_id": "a78e765c18e92a45be1569055d3f47fc92900c6b",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdh_secp384r1_test.txt",
      "new_id": "10c07739de13f8bfe474b800d42b0b2002de40ec",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdh_secp384r1_test.txt"
    },
    {
      "type": "modify",
      "old_id": "a552982e776cfddfc5e7e4ea308c91f85bf07ce6",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdh_secp521r1_test.txt",
      "new_id": "8e23c051cb6776d38a2030f870c7977181d37b7c",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdh_secp521r1_test.txt"
    },
    {
      "type": "modify",
      "old_id": "da1db0a92a43ef96a03b5096b800f2e016c183b1",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp224r1_sha224_test.txt",
      "new_id": "6741e06a5a40ac2b59cb680f3db5bcceb7b1f8a8",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp224r1_sha224_test.txt"
    },
    {
      "type": "modify",
      "old_id": "4d1e613e1bcfb5983a47041356b5a037f8354501",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp224r1_sha256_test.txt",
      "new_id": "e652c2086bad0c2fa49319fdb630e742f0b73e6e",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp224r1_sha256_test.txt"
    },
    {
      "type": "modify",
      "old_id": "30af5416a9dc4f6f74161084a240fb1397cedd1c",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp224r1_sha512_test.txt",
      "new_id": "839815ff81a3bfa5f44ac9cde4aaba72207d7461",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp224r1_sha512_test.txt"
    },
    {
      "type": "modify",
      "old_id": "8a1a333530b462956f287c2f352afd170d2d56a9",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp256r1_sha256_test.txt",
      "new_id": "01c0caafc66688594157642374d11700263d74cf",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp256r1_sha256_test.txt"
    },
    {
      "type": "modify",
      "old_id": "10c37359686f066eb0a4b40079f58d1d4b5517d7",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp256r1_sha512_test.txt",
      "new_id": "0c6efb8e4c5b24de663489f64a782df99586ba03",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp256r1_sha512_test.txt"
    },
    {
      "type": "modify",
      "old_id": "f110c79528b21534a7d5bb263e500af564978dc2",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp384r1_sha384_test.txt",
      "new_id": "6a943995ed98ed9bc82930ea8d80131b5e1d756f",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp384r1_sha384_test.txt"
    },
    {
      "type": "modify",
      "old_id": "782d42bfc98899d40328a000abc887105136ee69",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp384r1_sha512_test.txt",
      "new_id": "0c45cda71ca395c843014e57d65bc9e0e04695e5",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp384r1_sha512_test.txt"
    },
    {
      "type": "modify",
      "old_id": "58bf90acf9ca7a0e2ecb16f4b0938e1332d9429a",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/ecdsa_secp521r1_sha512_test.txt",
      "new_id": "35a7eb74be6a0f7fc33a30f5769c1be36eedbbe2",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/ecdsa_secp521r1_sha512_test.txt"
    },
    {
      "type": "modify",
      "old_id": "dec273e6f4cc678b76678f050951ebd19ec00ac7",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/eddsa_test.txt",
      "new_id": "55afb2b04e9b5597665447ad217274719f79c7e3",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/eddsa_test.txt"
    },
    {
      "type": "modify",
      "old_id": "e531083bebd17df05f2985a72e0ec3bd6c2f38d2",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/hkdf_sha1_test.txt",
      "new_id": "35b9054f281cbb0d99590e2a69975f5b0a356fa3",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/hkdf_sha1_test.txt"
    },
    {
      "type": "modify",
      "old_id": "744db97d7d59aec9f80c11d15debcf781e479422",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/hkdf_sha256_test.txt",
      "new_id": "d69bb3cb3f2ec1db6a506a71a0c3b952056312a1",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/hkdf_sha256_test.txt"
    },
    {
      "type": "modify",
      "old_id": "3350b7515592ce6c6c35de4f201f004c09443e90",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/hkdf_sha384_test.txt",
      "new_id": "bdb4731def0fab0b86f0d76b6626799d7546c710",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/hkdf_sha384_test.txt"
    },
    {
      "type": "modify",
      "old_id": "129ff7e4368b0596f55b7c6f68f59ec047177c89",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/hkdf_sha512_test.txt",
      "new_id": "b03dcd7624f938d91e0d20b2a6f6332bd6a7cf62",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/hkdf_sha512_test.txt"
    },
    {
      "type": "modify",
      "old_id": "c7f9cbe41910ec16e8be355d80891057dcdae06a",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/kwp_test.txt",
      "new_id": "9c05b42dbe1198ee8e646e61af8538eb5949eb05",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/kwp_test.txt"
    },
    {
      "type": "modify",
      "old_id": "c8789e105a961262a04e46ce8d5e69060b3bc179",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/rsa_pss_2048_sha1_mgf1_20_test.txt",
      "new_id": "91636928bac26788484d6ad42504778d4137cdbe",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/rsa_pss_2048_sha1_mgf1_20_test.txt"
    },
    {
      "type": "modify",
      "old_id": "d3d6bcd90cc643448962a544c3ae0bdb18c09188",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/rsa_pss_misc_test.txt",
      "new_id": "a77f9a9519076c0a834f445d7f176b89d9cd6f6c",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/rsa_pss_misc_test.txt"
    },
    {
      "type": "modify",
      "old_id": "4a1e99bd2d8cc35d4ae8ec25ea51ffd7b8168224",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/rsa_signature_test.txt",
      "new_id": "81b8d6399d2a7545b46d62eccbc2e7bc955caa18",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/rsa_signature_test.txt"
    },
    {
      "type": "modify",
      "old_id": "11eab81967c0ccc5d22f9c337c952a8a10410f71",
      "old_mode": 33188,
      "old_path": "third_party/wycheproof_testvectors/x25519_test.txt",
      "new_id": "f49bce45e60e600bcc8824523e2aa11597d6222e",
      "new_mode": 33188,
      "new_path": "third_party/wycheproof_testvectors/x25519_test.txt"
    },
    {
      "type": "modify",
      "old_id": "c774cc56dbc80625dafa5908a6af0899f6a3ad29",
      "old_mode": 33188,
      "old_path": "util/convert_wycheproof.go",
      "new_id": "ffb5cf9eeac4f14e6dfe9ab0d82f77c4b26065bb",
      "new_mode": 33188,
      "new_path": "util/convert_wycheproof.go"
    }
  ]
}
