commit 81138bc861023edda4816e1a89398f32c3b68e23
author David Benjamin <davidben@google.com> Tue Jan 23 14:53:40 2024 -0500
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 23 21:42:57 2024 +0000
tree db4c1d6d7957e2381c720d214504b32760d9cc3b
parent 90ceeb021579cdec2c1dd663a5f993e7161f5082

Stop passing der::Input by const-ref

Span/view types are small enough that the guidance these days is to pass
by value. This CL is the result of two sed lines:

  sed -i -e 's/const Input &/Input /g' pki/*.*
  sed -i -e 's/const der::Input &/der::Input /g' pki/*.*

Plus one manual fix inside a comment in pki/parser.h where the spacing
didn't match. Then a clang-format -i

Change-Id: I29c9ffc7ddf2df5822e5335f108c85ecbf496a3c
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65669
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Matt Mueller <mattm@google.com>

pki/path_builder.cc

diff --git a/pki/path_builder.cc b/pki/path_builder.cc
index 07ced15..98c6438 100644
--- a/pki/path_builder.cc
+++ b/pki/path_builder.cc
@@ -621,7 +621,8 @@
         // trusted root.
         if (!cur_path_.Empty()) {
           if (delegate->IsDebugLogEnabled()) {
-            delegate->DebugLog("Issuer is a trust leaf, considering as UNSPECIFIED");
+            delegate->DebugLog(
+                "Issuer is a trust leaf, considering as UNSPECIFIED");
           }
           next_issuer_.trust = CertificateTrust::ForUnspecified();
         }
@@ -692,7 +693,8 @@
             std::move(next_issuer_.cert), &cert_issuer_sources_, trust_store_));
         next_issuer_ = IssuerEntry();
         if (delegate->IsDebugLogEnabled()) {
-          delegate->DebugLog("CertPathIter cur_path_ =\n" + cur_path_.PathDebugString());
+          delegate->DebugLog("CertPathIter cur_path_ =\n" +
+                             cur_path_.PathDebugString());
         }
         // Continue descending the tree.
         continue;