Stop passing der::Input by const-ref Span/view types are small enough that the guidance these days is to pass by value. This CL is the result of two sed lines: sed -i -e 's/const Input &/Input /g' pki/*.* sed -i -e 's/const der::Input &/der::Input /g' pki/*.* Plus one manual fix inside a comment in pki/parser.h where the spacing didn't match. Then a clang-format -i Change-Id: I29c9ffc7ddf2df5822e5335f108c85ecbf496a3c Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65669 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Matt Mueller <mattm@google.com>
diff --git a/pki/crl.h b/pki/crl.h index 445c6e8..d527de9 100644 --- a/pki/crl.h +++ b/pki/crl.h
@@ -43,7 +43,7 @@ // signatureAlgorithm AlgorithmIdentifier, // signatureValue BIT STRING } [[nodiscard]] OPENSSL_EXPORT bool ParseCrlCertificateList( - const der::Input &crl_tlv, der::Input *out_tbs_cert_list_tlv, + der::Input crl_tlv, der::Input *out_tbs_cert_list_tlv, der::Input *out_signature_algorithm_tlv, der::BitString *out_signature_value); @@ -77,7 +77,7 @@ // -- if present, version MUST be v2 // } [[nodiscard]] OPENSSL_EXPORT bool ParseCrlTbsCertList( - const der::Input &tbs_tlv, ParsedCrlTbsCertList *out); + der::Input tbs_tlv, ParsedCrlTbsCertList *out); // Represents a CRL "Version" from RFC 5280. TBSCertList reuses the same // Version definition from TBSCertificate, however only v1(not present) and @@ -180,12 +180,12 @@ // indirectCRL [4] BOOLEAN DEFAULT FALSE, // onlyContainsAttributeCerts [5] BOOLEAN DEFAULT FALSE } [[nodiscard]] OPENSSL_EXPORT bool ParseIssuingDistributionPoint( - const der::Input &extension_value, + der::Input extension_value, std::unique_ptr<GeneralNames> *out_distribution_point_names, ContainedCertsType *out_only_contains_cert_type); OPENSSL_EXPORT CRLRevocationStatus -GetCRLStatusForCert(const der::Input &cert_serial, CrlVersion crl_version, +GetCRLStatusForCert(der::Input cert_serial, CrlVersion crl_version, const std::optional<der::Input> &revoked_certificates_tlv); // Checks the revocation status of the certificate |cert| by using the