commit 81138bc861023edda4816e1a89398f32c3b68e23
author David Benjamin <davidben@google.com> Tue Jan 23 14:53:40 2024 -0500
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 23 21:42:57 2024 +0000
tree db4c1d6d7957e2381c720d214504b32760d9cc3b
parent 90ceeb021579cdec2c1dd663a5f993e7161f5082

Stop passing der::Input by const-ref

Span/view types are small enough that the guidance these days is to pass
by value. This CL is the result of two sed lines:

  sed -i -e 's/const Input &/Input /g' pki/*.*
  sed -i -e 's/const der::Input &/der::Input /g' pki/*.*

Plus one manual fix inside a comment in pki/parser.h where the spacing
didn't match. Then a clang-format -i

Change-Id: I29c9ffc7ddf2df5822e5335f108c85ecbf496a3c
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65669
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Matt Mueller <mattm@google.com>

pki/crl.cc

diff --git a/pki/crl.cc b/pki/crl.cc
index 187a034..cc9c878 100644
--- a/pki/crl.cc
+++ b/pki/crl.cc
@@ -26,7 +26,7 @@
 // In dotted notation: 2.5.29.28
 inline constexpr uint8_t kIssuingDistributionPointOid[] = {0x55, 0x1d, 0x1c};
 
-[[nodiscard]] bool NormalizeNameTLV(const der::Input &name_tlv,
+[[nodiscard]] bool NormalizeNameTLV(der::Input name_tlv,
                                     std::string *out_normalized_name) {
   der::Parser parser(name_tlv);
   der::Input name_rdn;
@@ -48,7 +48,7 @@
 
 }  // namespace
 
-bool ParseCrlCertificateList(const der::Input &crl_tlv,
+bool ParseCrlCertificateList(der::Input crl_tlv,
                              der::Input *out_tbs_cert_list_tlv,
                              der::Input *out_signature_algorithm_tlv,
                              der::BitString *out_signature_value) {
@@ -92,7 +92,7 @@
   return true;
 }
 
-bool ParseCrlTbsCertList(const der::Input &tbs_tlv, ParsedCrlTbsCertList *out) {
+bool ParseCrlTbsCertList(der::Input tbs_tlv, ParsedCrlTbsCertList *out) {
   der::Parser parser(tbs_tlv);
 
   //   TBSCertList  ::=  SEQUENCE  {
@@ -196,7 +196,7 @@
 }
 
 bool ParseIssuingDistributionPoint(
-    const der::Input &extension_value,
+    der::Input extension_value,
     std::unique_ptr<GeneralNames> *out_distribution_point_names,
     ContainedCertsType *out_only_contains_cert_type) {
   der::Parser idp_extension_value_parser(extension_value);
@@ -303,7 +303,7 @@
 }
 
 CRLRevocationStatus GetCRLStatusForCert(
-    const der::Input &cert_serial, CrlVersion crl_version,
+    der::Input cert_serial, CrlVersion crl_version,
     const std::optional<der::Input> &revoked_certificates_tlv) {
   if (!revoked_certificates_tlv.has_value()) {
     // RFC 5280 Section 5.1.2.6: "When there are no revoked certificates, the