commit 7d2dbc379197cd6477c27da150f811084b124841
author David Benjamin <davidben@google.com> Sat Mar 25 18:22:58 2017 -0500
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Sat Mar 25 23:28:45 2017 +0000
tree a0bd71f74deff4bf1980502b4159c2fc9dc86f11
parent e3843d41b9657f458a6b74034cf5c23c04c39f2a

Add a comment around the set_{min,max}_version logic.

It's not immediately obvious what's going on here.

Change-Id: Ibbba80a6ff9ace4d88e89a42efc270b77b4fad12
Reviewed-on: https://boringssl-review.googlesource.com/14368
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

ssl/ssl_lib.c

diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
index 88d5f29..2405306 100644
--- a/ssl/ssl_lib.c
+++ b/ssl/ssl_lib.c
@@ -924,6 +924,7 @@
 
 static int set_min_version(const SSL_PROTOCOL_METHOD *method, uint16_t *out,
                            uint16_t version) {
+  /* Zero is interpreted as the default minimum version. */
   if (version == 0) {
     *out = method->min_version;
     return 1;
@@ -938,6 +939,7 @@
 
 static int set_max_version(const SSL_PROTOCOL_METHOD *method, uint16_t *out,
                            uint16_t version) {
+  /* Zero is interpreted as the default maximum version. */
   if (version == 0) {
     *out = method->max_version;
     /* TODO(svaldez): Enable TLS 1.3 by default once fully implemented. */