| commit | 93d9743def881bdf106e6496d917aeeae686b094 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Aug 08 21:22:47 2016 -0400 |
| committer | Adam Langley <agl@google.com> | Fri Aug 19 16:24:09 2016 +0000 |
| tree | 5364dbc2577d69ab6dd46d08b2762bed051e4cc8 | |
| parent | 46662482b898da0fee9ac49dea0b532eb60d84ef [diff] |
Deprecate and no-op SSL_set_verify_result. As documented by OpenSSL, it does not interact with session resumption correctly: https://www.openssl.org/docs/manmaster/ssl/SSL_set_verify_result.html Sadly, netty-tcnative calls it, but we should be able to get them to take it out because it doesn't do anything. Two of the three calls are immediately after SSL_new. In OpenSSL and BoringSSL as of the previous commit, this does nothing. The final call is in verify_callback (see SSL_set_verify). This callback is called in X509_verify_cert by way of X509_STORE_CTX_set_verify_cb. As soon as X509_verify_cert returns, ssl->verify_result is clobbered anyway, so it doesn't do anything. Within OpenSSL, it's used in testdane.c. As far as I can tell, it does not actually do a handshake and just uses this function to fake having done one. (Regardless, we don't need to build against that.) This is done in preparation for removing ssl->verify_result in favor of session->verify_result. Change-Id: I7e32d7f26c44f70136c72e58be05a3a43e62582b Reviewed-on: https://boringssl-review.googlesource.com/10485 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: