commit 79b8b3a41982f9760faaea706378a78d40c16b62
author David Benjamin <davidben@google.com> Fri Aug 16 18:58:13 2019 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Aug 20 13:51:08 2019 +0000
tree 18b800e8d6c8d1d44f4f883719a5101f20526a9f
parent 9806ae005b3085683a2fcf2953e4170893e0973d

Switch tls13_enc.cc to spans.

The callers become filled with MakeConstSpans, but the various TLS 1.3
secrets will get fixed in a subsequent CL. We do still need a better
pattern for the EVP_MAX_MD_SIZE buffers.

Change-Id: Ide9c173bf0760ecdb8cc45e63969457c20310de2
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/37125
Commit-Queue: Steven Valdez <svaldez@google.com>
Reviewed-by: Steven Valdez <svaldez@google.com>

ssl/handshake_client.cc

diff --git a/ssl/handshake_client.cc b/ssl/handshake_client.cc
index e1a506a..e1b6afe 100644
--- a/ssl/handshake_client.cc
+++ b/ssl/handshake_client.cc
@@ -456,11 +456,13 @@
     return ssl_hs_error;
   }
 
-  if (!tls13_init_early_key_schedule(hs, ssl->session->master_key,
-                                     ssl->session->master_key_length) ||
+  if (!tls13_init_early_key_schedule(
+          hs, MakeConstSpan(ssl->session->master_key,
+                            ssl->session->master_key_length)) ||
       !tls13_derive_early_secrets(hs) ||
-      !tls13_set_traffic_key(ssl, ssl_encryption_early_data, evp_aead_seal,
-                             hs->early_traffic_secret, hs->hash_len)) {
+      !tls13_set_traffic_key(
+          ssl, ssl_encryption_early_data, evp_aead_seal,
+          MakeConstSpan(hs->early_traffic_secret, hs->hash_len))) {
     return ssl_hs_error;
   }