Predeclare enums in base.h Including ssl.h is quite a chunk of code and #defines, so we've tried to limit its spread internally in the interests of code hygine given that we have a multi-billion-line repo. However, header files that mention enums from ssl.h currently need to include ssl.h. For example, your class may have static class member functions intended to be callbacks, and they need to be class members because they'll call other private methods. C cannot predeclare enums, but C++ can if you explicitly type them. Sadly C doesn't support explicit types. So option one is to move the enums into base.h. That works, but the enums properly live in ssl.h and reading the header file is a lot clearer if you don't have to jump around to see all the pieces. So option two (this change) is to explicitly type and predelcare the enums in base.h for C++ only. The worry now is that C and C++ might disagree about the type of the enums. However, this has already happened: at least for |ssl_private_key_result_t|, g++ thinks that it's an |int| (without any explicit type) and gcc thinks that it's an |unsigned|. At least they're the same length, I guess? So, to make sure that this doesn't slip any more, this change also adds |ssl_test_c.c| which tests that C views the enums as having the same size as an |int|, at least. Change-Id: I8248583ec997021f8226d5a798609f6afc96dac4 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/35664 Reviewed-by: Adam Langley <agl@google.com> Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: Adam Langley <agl@google.com>
diff --git a/ssl/CMakeLists.txt b/ssl/CMakeLists.txt index dc89dca..0fb532e 100644 --- a/ssl/CMakeLists.txt +++ b/ssl/CMakeLists.txt
@@ -50,6 +50,7 @@ span_test.cc ssl_test.cc + ssl_c_test.c $<TARGET_OBJECTS:boringssl_gtest_main> )