commit 6add9f172c88a81931d22aeaf18ce4553588d35e
author David Benjamin <davidben@google.com> Fri Jan 06 16:02:39 2017 -0500
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Fri Jan 06 21:15:28 2017 +0000
tree 02a6062e366fc21eb42e8c9803218d0ca7dd8cee
parent 45573cc04d6cc3352082b6a523e2ad1bfd909d94

Fix setsockopt call.

Neither Windows nor POSIX uses a char for SO_REUSEADDR. Windows uses
BOOL (which is actually int) and POSIX uses int. Windows also requires a
cast due to using char* instead of void*. Thanks to Daniel Hirche for
reporting.

Change-Id: I01c847c8da285f27f3c3cdf5ff58b53899098b82
Reviewed-on: https://boringssl-review.googlesource.com/13100
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

tool/transport_common.cc

diff --git a/tool/transport_common.cc b/tool/transport_common.cc
index 5017315..cd3e0d6 100644
--- a/tool/transport_common.cc
+++ b/tool/transport_common.cc
@@ -159,7 +159,11 @@
   addr.sin6_port = htons(atoi(port.c_str()));
 
   bool ok = false;
-  const char enable = 1;
+#if defined(OPENSSL_WINDOWS)
+  const BOOL enable = TRUE;
+#else
+  const int enable = 1;
+#endif
   int server_sock = -1;
 
   server_sock =
@@ -169,7 +173,7 @@
     goto out;
   }
 
-  if (setsockopt(server_sock, SOL_SOCKET, SO_REUSEADDR, &enable,
+  if (setsockopt(server_sock, SOL_SOCKET, SO_REUSEADDR, (const char *)&enable,
                  sizeof(enable)) < 0) {
     perror("setsockopt");
     goto out;