Separate client and server certificate_types.
This is the first of reorganizing state between connection state and handshake
state. The existing set are retained in cert_st for the server; they are server
configuration. The client gets a copy in s->s3->tmp alongside other handshake
state.
With other handshake state moved there, hopefully we can reset that state in
one go and possibly not even maintain it when there is no handshake in
progress. Rather than currently where we sometimes confused connection state
and handshake state and have to reset as appropriate on renegotiate.
While I'm here, document the fields and name them something more useful than
'ctypes'.
Change-Id: Ib927579f0004fc5c6854fce2127625df669b2b6d
Reviewed-on: https://boringssl-review.googlesource.com/1113
Reviewed-by: Adam Langley <agl@google.com>
diff --git a/ssl/ssl_locl.h b/ssl/ssl_locl.h
index 95ba123..d2a8dc5 100644
--- a/ssl/ssl_locl.h
+++ b/ssl/ssl_locl.h
@@ -564,11 +564,11 @@
unsigned int cert_flags;
CERT_PKEY pkeys[SSL_PKEY_NUM];
- /* Certificate types (received or sent) in certificate request
- * message.
+ /* Server-only: client_certificate_types is list of certificate types to
+ * include in the CertificateRequest message.
*/
- unsigned char *ctypes;
- size_t ctype_num;
+ unsigned char *client_certificate_types;
+ size_t num_client_certificate_types;
/* signature algorithms peer reports: e.g. supported signature
* algorithms extension for server or as part of a certificate
