| commit | 63c8e81ace7f21269e482429860ca28537cafe3b | [log] [tgz] |
|---|---|---|
| author | Lukas Zobernig <zlukas@google.com> | Tue Oct 28 14:15:27 2025 +0000 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 28 08:35:29 2025 -0700 |
| tree | a50b5fb49e8d24dc186a3d46befbec8055f6ae90 | |
| parent | 58da9b0d721fd807279f4e3898741c92cf43bdbd [diff] |
Fix potential constant time issue The old code contained an explicit "nibble % 5", which could have generated a non-constant time division operation. This change replaces it by an equivalent mul-shift-mul that is manifest constant time. It appears that Clang, GCC, and MSVC will all replace constant divisions with such a construction with optimizations on, so this is unlikely to have caused a leak in practice. However, Clang and MSVC will emit division instructions with optimizations off. Thanks to Filippo Valsorda for reporting this. Bug: 455829614 Change-Id: I7bffaaf4fc79196b27631de6edd8c97b0ec97a89 Signed-off-by: Lukas Zobernig <zlukas@google.com> Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/83348 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: