)]}'
{
  "commit": "5bcaa113e285b98f8d8ebbf9f5f5a991fc95e307",
  "tree": "efa5f27762239e861f07f88ca7a96a1dafa59d46",
  "parents": [
    "e15019572b3294e3410a4ee6d4bcbbf76450df31"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sat Dec 16 15:34:00 2017 -0500"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Wed Jan 03 22:15:11 2018 +0000"
  },
  "message": "Tighten EC_KEY\u0027s association with its group.\n\nThis is to simplify\nhttps://boringssl-review.googlesource.com/c/boringssl/+/24445/.\n\nSetting or changing an EC_KEY\u0027s group after the public or private keys\nhave been configured is quite awkward w.r.t. consistency checks. It\nbecomes additionally messy if we mean to store private keys as\nEC_SCALARs (and avoid the BIGNUM timing leak), whose size is\ncurve-dependent.\n\nInstead, require that callers configure the group before setting either\nhalf of the keypair. Additionally, reject EC_KEY_set_group calls that\nchange the group. This will simplify clearing one more BIGNUM timing\nleak.\n\nUpdate-Note: This will break code which sets the group and key in a\n    weird order. I checked calls of EC_KEY_new and confirmed they all\n    set the group first. If I missed any, let me know.\n\nChange-Id: Ie89f90a318b31b6b98f71138e5ff3de5323bc9a6\nReviewed-on: https://boringssl-review.googlesource.com/24425\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCQ-Verified: CQ bot account: commit-bot@chromium.org \u003ccommit-bot@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f64cb21e6616417faa0bcbc61a6e5584cfc20683",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/ec_key.c",
      "new_id": "4e0bcb2262d3be3b5f160da45bf1f75f8c6341c8",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/ec_key.c"
    },
    {
      "type": "modify",
      "old_id": "8e7a81d9d1b7b3344e337000f9ff9e16e1379dae",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/ec_test.cc",
      "new_id": "d2cd2afb4c8e33c8d041749059ba54566152de15",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/ec_test.cc"
    },
    {
      "type": "modify",
      "old_id": "7ef1b1418445f4cf4d69ca0d344575ad8ee4fc10",
      "old_mode": 33188,
      "old_path": "include/openssl/ec_key.h",
      "new_id": "5fe031861a3941b6258e976cd54c34786d60b34e",
      "new_mode": 33188,
      "new_path": "include/openssl/ec_key.h"
    }
  ]
}