)]}'
{
  "commit": "5b33effa7206b77e542a4ad6ec570aa27ed83518",
  "tree": "b6895edd725dc911b10a2bd148b72ef431702be3",
  "parents": [
    "1764d7a3ea5f5857f7e5a19b1674455e88b4c58d"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sat Sep 22 16:52:48 2018 -0700"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Wed Sep 26 19:10:02 2018 +0000"
  },
  "message": "Rename OPENSSL_NO_THREADS, part 1.\n\nBoringSSL depends on the platform\u0027s locking APIs to make internal global\nstate thread-safe, including the PRNG. On some single-threaded embedded\nplatforms, locking APIs may not exist, so this dependency may be disabled\nwith a build flag.\n\nDoing so means the consumer promises the library will never be used in any\nmulti-threaded address space. It causes BoringSSL to be globally thread-unsafe.\nSetting it inappropriately will subtly and unpredictably corrupt memory and\nleak secret keys.\n\nUnfortunately, folks sometimes misinterpreted OPENSSL_NO_THREADS as skipping an\ninternal thread pool or disabling an optionally extra-thread-safe mode. This is\nnot and has never been the case. Rename it to\nOPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED to clarify what\nthis option does.\n\nUpdate-Note: As a first step, this CL makes both OPENSSL_NO_THREADS and\nOPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED work. A later CL\nwill remove the old name, so migrate callers after or at the same time as\npicking up this CL.\n\nChange-Id: Ibe4964ae43eb7a52f08fd966fccb330c0cc11a8c\nReviewed-on: https://boringssl-review.googlesource.com/32084\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nCQ-Verified: CQ bot account: commit-bot@chromium.org \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0e8ae3a6f2ede912346d2cd56e49d3c38407f305",
      "old_mode": 33188,
      "old_path": "crypto/internal.h",
      "new_id": "6944d56a8ede6f9da1d858f873caaa0dc2849a22",
      "new_mode": 33188,
      "new_path": "crypto/internal.h"
    },
    {
      "type": "modify",
      "old_id": "62fb17ddc775476a490c57164d4df76d3391351c",
      "old_mode": 33188,
      "old_path": "crypto/pool/pool_test.cc",
      "new_id": "8f32fb6f23af7140af4c64154f508a5d46598249",
      "new_mode": 33188,
      "new_path": "crypto/pool/pool_test.cc"
    },
    {
      "type": "modify",
      "old_id": "bd2eb1882571308ce76a3e767532a2aac3ed30b1",
      "old_mode": 33188,
      "old_path": "crypto/rand_extra/rand_test.cc",
      "new_id": "183c4f77d95338e64357e829d87c37328ac7e510",
      "new_mode": 33188,
      "new_path": "crypto/rand_extra/rand_test.cc"
    },
    {
      "type": "modify",
      "old_id": "6ce0746d34da07c6d563d3029a0f40aa4efe1fa4",
      "old_mode": 33188,
      "old_path": "crypto/refcount_test.cc",
      "new_id": "700863f6995ff9eb23efc234a5dcbf6d444cf2d7",
      "new_mode": 33188,
      "new_path": "crypto/refcount_test.cc"
    },
    {
      "type": "modify",
      "old_id": "b0a0b7e49e372d68e3fc91b5c43aafee472eba1e",
      "old_mode": 33188,
      "old_path": "crypto/rsa_extra/rsa_test.cc",
      "new_id": "9bd47b1b5fdfc288e6c0664943090788788cd5bb",
      "new_mode": 33188,
      "new_path": "crypto/rsa_extra/rsa_test.cc"
    },
    {
      "type": "modify",
      "old_id": "718d96016f845104f383fe0582946d910e10bd39",
      "old_mode": 33188,
      "old_path": "crypto/thread_none.c",
      "new_id": "4f07b9d9c8ad6eb1fe0309cf5426c3e551ca24b2",
      "new_mode": 33188,
      "new_path": "crypto/thread_none.c"
    },
    {
      "type": "modify",
      "old_id": "f89b22ec29b009fa6c59a3b8b01cb603f432994d",
      "old_mode": 33188,
      "old_path": "crypto/thread_test.cc",
      "new_id": "f9fad9beba78a77cc2d846e80cb200404fd6d1c9",
      "new_mode": 33188,
      "new_path": "crypto/thread_test.cc"
    },
    {
      "type": "modify",
      "old_id": "d134993477b803a12e07f039bd849ec3fc1be7fe",
      "old_mode": 33188,
      "old_path": "include/openssl/base.h",
      "new_id": "e287de730c20bd63ea3afe72b48fc50337c18f5c",
      "new_mode": 33188,
      "new_path": "include/openssl/base.h"
    },
    {
      "type": "modify",
      "old_id": "98073b0789a0b54788ed697cb1fe06561a457cab",
      "old_mode": 33188,
      "old_path": "include/openssl/thread.h",
      "new_id": "91706fec2ca50d370a3e3c2c8212c3d88097626b",
      "new_mode": 33188,
      "new_path": "include/openssl/thread.h"
    },
    {
      "type": "modify",
      "old_id": "894bb14ec0fc98f521a4fc69ceadb2136aa478df",
      "old_mode": 33188,
      "old_path": "ssl/ssl_test.cc",
      "new_id": "61a47d3dc59771b2fe888b8f0aeb95b545087b6a",
      "new_mode": 33188,
      "new_path": "ssl/ssl_test.cc"
    }
  ]
}