Don't use init_buf in DTLS.
This machinery is so different between TLS and DTLS that there is no
sense in having them share structures. This switches us to maintaining
the full reassembled message in hm_fragment and get_message just lets
the caller read out of that when ready.
This removes the last direct handshake dependency on init_buf,
ssl3_hash_message.
Change-Id: I4eccfb6e6021116255daead5359a0aa3f4d5be7b
Reviewed-on: https://boringssl-review.googlesource.com/8667
Reviewed-by: Steven Valdez <svaldez@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
diff --git a/ssl/dtls_method.c b/ssl/dtls_method.c
index f6376bb..09c7d40 100644
--- a/ssl/dtls_method.c
+++ b/ssl/dtls_method.c
@@ -91,26 +91,10 @@
}
static int dtls1_begin_handshake(SSL *ssl) {
- if (ssl->init_buf != NULL) {
- return 1;
- }
-
- BUF_MEM *buf = BUF_MEM_new();
- if (buf == NULL || !BUF_MEM_reserve(buf, SSL3_RT_MAX_PLAIN_LENGTH)) {
- BUF_MEM_free(buf);
- return 0;
- }
-
- ssl->init_buf = buf;
- ssl->init_num = 0;
return 1;
}
static void dtls1_finish_handshake(SSL *ssl) {
- BUF_MEM_free(ssl->init_buf);
- ssl->init_buf = NULL;
- ssl->init_num = 0;
-
ssl->d1->handshake_read_seq = 0;
ssl->d1->handshake_write_seq = 0;
dtls_clear_incoming_messages(ssl);
@@ -127,6 +111,7 @@
dtls1_begin_handshake,
dtls1_finish_handshake,
dtls1_get_message,
+ dtls1_hash_current_message,
dtls1_read_app_data,
dtls1_read_change_cipher_spec,
dtls1_read_close_notify,
