commit 3ab1a69545f8c02abfe2de3e3c730044f4ded49e
author sphawk <sphawk80@gmail.com> Sun Mar 11 19:20:51 2018 +0900
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Thu Mar 15 17:52:23 2018 +0000
tree 1c884d0dbeb50b13500c2c2ee3d16fbdddf891a9
parent fa3e9c3385fc872b705b81860139616851829a71

fix compilation error for non-english windows (like cjk)

add /utf-8 switch for msvc build. source code has several utf-8 characters
fix C2001 error. escape non-printable ascii code generated by embed_test_data.go
fix C4819 warning. add u8 keyword on utf-8 string literal (ripemd_test.cc)

Change-Id: I8c04dc7f0359e6ee27efada066863826d263d5cd
Reviewed-on: https://boringssl-review.googlesource.com/26484
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c496528..4445b55 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -160,8 +160,8 @@
                             ${MSVC_DISABLED_WARNINGS_LIST})
   string(REPLACE "C" " -w4" MSVC_LEVEL4_WARNINGS_STR
                             ${MSVC_LEVEL4_WARNINGS_LIST})
-  set(CMAKE_C_FLAGS   "-Wall -WX ${MSVC_DISABLED_WARNINGS_STR} ${MSVC_LEVEL4_WARNINGS_STR}")
-  set(CMAKE_CXX_FLAGS "-Wall -WX ${MSVC_DISABLED_WARNINGS_STR} ${MSVC_LEVEL4_WARNINGS_STR}")
+  set(CMAKE_C_FLAGS   "-utf-8 -Wall -WX ${MSVC_DISABLED_WARNINGS_STR} ${MSVC_LEVEL4_WARNINGS_STR}")
+  set(CMAKE_CXX_FLAGS "-utf-8 -Wall -WX ${MSVC_DISABLED_WARNINGS_STR} ${MSVC_LEVEL4_WARNINGS_STR}")
 endif()
 
 if(WIN32)

decrepit/ripemd/ripemd_test.cc

diff --git a/decrepit/ripemd/ripemd_test.cc b/decrepit/ripemd/ripemd_test.cc
index 5c54196..0700bae 100644
--- a/decrepit/ripemd/ripemd_test.cc
+++ b/decrepit/ripemd/ripemd_test.cc
@@ -109,7 +109,7 @@
       0x37, 0xf9, 0x7f, 0x68, 0xf0, 0x83, 0x25, 0xdc, 0x15, 0x28};
 
   if (OPENSSL_memcmp(digest, kMillionADigest, sizeof(digest)) != 0) {
-    fprintf(stderr, "Digest incorrect for “million a's” test: ");
+    fprintf(stderr, u8"Digest incorrect for “million a's” test: ");
     hexdump(stderr, "", digest, sizeof(digest));
     ok = 0;
   }

util/embed_test_data.go

diff --git a/util/embed_test_data.go b/util/embed_test_data.go
index ffc446b..a083848 100644
--- a/util/embed_test_data.go
+++ b/util/embed_test_data.go
@@ -21,7 +21,6 @@
 	"fmt"
 	"io/ioutil"
 	"os"
-	"unicode"
 )
 
 func quote(in []byte) string {
@@ -46,7 +45,8 @@
 		case '"':
 			buf.WriteString(`\"`)
 		default:
-			if rune(b) > 127 || unicode.IsPrint(rune(b)) {
+			// printable ascii code [32, 126]
+			if 32 <= b && b <= 126 {
 				buf.WriteByte(b)
 			} else {
 				fmt.Fprintf(&buf, "\\x%02x", b)