commit 310d3f63f38cf8a82fa9ae5032e343ba5159eb4d
author Adam Langley <agl@google.com> Tue Jul 12 10:39:20 2016 -0700
committer David Benjamin <davidben@google.com> Tue Jul 12 17:55:41 2016 +0000
tree 18b60b1a10d16a7771c2c7f36bc991d65fa5d307
parent 27516f7c9762c2b21ff4add87aa5b7ac41237575

Change |EVP_PKEY_up_ref| to return int.

Upstream have added |EVP_PKEY_up_ref|, but their version returns an int.
Having this function with a different signature like that is dangerous
so this change aligns BoringSSL with upstream. Users of this function in
Chromium and internally should already have been updated.

Change-Id: I0a7aeaf1a1ca3b0f0c635e2ee3826aa100b18157
Reviewed-on: https://boringssl-review.googlesource.com/8736
Reviewed-by: David Benjamin <davidben@google.com>

ssl/ssl_cert.c

diff --git a/ssl/ssl_cert.c b/ssl/ssl_cert.c
index d61f9f5..dead3ba 100644
--- a/ssl/ssl_cert.c
+++ b/ssl/ssl_cert.c
@@ -174,7 +174,8 @@
   }
 
   if (cert->privatekey != NULL) {
-    ret->privatekey = EVP_PKEY_up_ref(cert->privatekey);
+    EVP_PKEY_up_ref(cert->privatekey);
+    ret->privatekey = cert->privatekey;
   }
 
   if (cert->chain) {