Make ssl_parse_serverhello_use_srtp_ext return 0 on failure.

Match most other functions. 03973096f416e694b676160ca481553bb44738eb changed
the call site, but not the function itself.

Change-Id: Iac018cbed8a454f50fb0da5e2419f503d8cb652d
Reviewed-on: https://boringssl-review.googlesource.com/1060
Reviewed-by: Adam Langley <agl@google.com>

ssl/d1_srtp.c

diff --git a/ssl/d1_srtp.c b/ssl/d1_srtp.c
index c27d766..fb5d1e7 100644
--- a/ssl/d1_srtp.c
+++ b/ssl/d1_srtp.c
@@ -453,7 +453,7 @@
 		{
 		OPENSSL_PUT_ERROR(SSL, ssl_parse_serverhello_use_srtp_ext, SSL_R_BAD_SRTP_PROTECTION_PROFILE_LIST);
 		*out_alert = SSL_AD_DECODE_ERROR;
-		return 1;
+		return 0;
 		}
 
 	if (CBS_len(&srtp_mki) != 0)
@@ -461,7 +461,7 @@
 		/* Must be no MKI, since we never offer one. */
 		OPENSSL_PUT_ERROR(SSL, ssl_parse_serverhello_use_srtp_ext, SSL_R_BAD_SRTP_MKI_VALUE);
 		*out_alert = SSL_AD_ILLEGAL_PARAMETER;
-		return 1;
+		return 0;
 		}
 
 	clnt=SSL_get_srtp_profiles(s);
@@ -471,7 +471,7 @@
 		{
 		OPENSSL_PUT_ERROR(SSL, ssl_parse_serverhello_use_srtp_ext, SSL_R_NO_SRTP_PROFILES);
 		*out_alert = SSL_AD_DECODE_ERROR;
-		return 1;
+		return 0;
 		}
     
 	/* Check to see if the server gave us something we support
@@ -485,13 +485,13 @@
 			{
 			s->srtp_profile=prof;
 			*out_alert = 0;
-			return 0;
+			return 1;
 			}
 		}
 
 	OPENSSL_PUT_ERROR(SSL, ssl_parse_serverhello_use_srtp_ext, SSL_R_BAD_SRTP_PROTECTION_PROFILE_LIST);
 	*out_alert = SSL_AD_ILLEGAL_PARAMETER;
-	return 1;
+	return 0;
 	}