Don't allow half-empty EVP_PKEYs to be passed into various APIs OpenSSL's API is poorly-typed and exposes many variations on empty states. They are not reachable from typical callers, this is merely a typing error in the OpenSSL API. Performing operations on such objects will sometimes crash. While not ideal, we do not consider this to be a security issue, nor much of a functional bug. Better would be to fix the APIs to eliminate as many half-empty states as possible, as we've been doing in crbug.com/42290409. Still, the X25519 one is difficult to avoid, so add some EVP-wide null checks on a few functions. Ultimately, however, this is a caller error. Bug: 42290409 Fixed: 489983951 Change-Id: I21dca6b3ee84659d812b9c17e5410fc5f516a7d0 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/90447 Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Lily Chen <chlily@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: