)]}' { "commit": "27b31cfc56b364edd058e040023750be84026007", "tree": "0c0200c5febecc937df7575c2592ff67cc69bebe", "parents": [ "25773430c07075a368416c3646fa4b07daf4968a" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Mon Aug 09 20:59:18 2021 -0400" }, "committer": { "name": "Boringssl LUCI CQ", "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 08 21:08:03 2021 +0000" }, "message": "Correctly propagate errors in i2d functions.\n\ntasn_enc.c was missing lots of error checks and mixed up 0 and -1\nreturns. Document all the internal calling conventions, as best as I can\ntell, and fix things up.\n\nThere are also error cases it forgets to check (it generally does not\nnotice missing non-OPTIONAL fields). This CL only addresses errors it\nalready tries to report. Subsequent CLs will add in the missing error\ncases. And then if it all sticks, I\u0027m hoping we can rewrite this with\nCBB. Rewriting tsan_dec.c to CBS would also be good, but that will be\nmore difficult as we need to clear out BER first.\n\nUpdate-Note: Some error cases which were silently misinterpreted as\nmissing OPTIONAL elements will now cause encoding to fail.\n\nBug: 429\nChange-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "f40aa860f12a8779946e0fe146222042c1645dd3", "old_mode": 33188, "old_path": "crypto/asn1/internal.h", "new_id": "b995ede9743e84fd24cc8f439821cebfc3e70bc6", "new_mode": 33188, "new_path": "crypto/asn1/internal.h" }, { "type": "modify", "old_id": "142de6d33831ec678803aabf9f47029ab32f3ef7", "old_mode": 33188, "old_path": "crypto/asn1/tasn_enc.c", "new_id": "51a860ded73ed570cd8e81341b2a6f132fb5e982", "new_mode": 33188, "new_path": "crypto/asn1/tasn_enc.c" } ] }