| commit | 24ee260fa5979efd6f80ccdef13c5e0192ce587f | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Apr 07 15:12:16 2025 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 08 12:23:55 2025 -0700 |
| tree | d6fc147debe20ab9557af2f06b64753ed7822d3b | |
| parent | 7fa475f44d7a38110c285527b9cb4900f68e3ccd [diff] |
Support ANY attribute values in X509_NAME
An attribute in an X.509 name is defined as
AttributeTypeAndValue ::= SEQUENCE {
type AttributeType,
value AttributeValue }
AttributeType ::= OBJECT IDENTIFIER
AttributeValue ::= ANY -- DEFINED BY AttributeType
However, OpenSSL only supported an ad-hoc subset of types. (See
crbug.com/42290275 for details). Fix this by doing two things:
1. Stop trying to use the MSTRING framework for AttributeValue as many
of these are decidedly not strings.
2. Reuse ASN1_TYPE's V_ASN1_OTHER representation for non-universal tags.
3. For NULL, OBJECT, and BOOLEAN, use V_ASN1_OTHER because the normal
representation is not an ASN1_STRING.
This is all wrapped up in a new, internal-only ASN1_ANY_AS_STRING type.
With this, MSTRING is no longer exposed to random unknown tags and we
can remove some default cases in our big switch/cases.
Update-Note: X.509 name attributes may now be any ASN.1 type, matching
the spec.
Additionally, a few obscure, unimplemented ASN.1 types changed
representation: ObjectDescriptor, EXTERNAL, REAL, EMBEDDED PDV,
RELATIVE-OID, and TIME (no connection to time types used in X.509) used
to be represented as ASN1_STRINGs with the type fields set to the
corresponding tag number, and their contents uninterpreted. Now they're
wrapped in V_ASN1_OTHER, consistent with ASN1_TYPE. This is not expected
to impact anyone.
Bug: 42290275
Change-Id: I54b0d72fcbfaeebae416aa96cdf74abdba8b4c88
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78329
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: