)]}' { "commit": "248ab817604707b669e546c86cb24f9d1ef67bd7", "tree": "f9a5d7b88bd9e8d849323757c1e2be6b7923faba", "parents": [ "3b6cebb1e052f5e4b41ca79f234d33fc709484e4" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Mon Aug 09 23:17:33 2021 -0400" }, "committer": { "name": "Boringssl LUCI CQ", "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 08 21:49:43 2021 +0000" }, "message": "Check for invalid CHOICE selectors in i2d functions.\n\nThis handles normal CHOICE types. A follow-up CL will handle MSTRING and\nANY types.\n\nUpdate-Note: An invalid CHOICE object (e.g. GENERAL_NAME) will now fail\nwhen encoded, rather than be silently omitted. In particular, CHOICE\nobjects are default-initialized by tasn_new.c in an empty -1 state.\nStructures containing a required CHOICE field can no longer be encoded\nwithout filling in the CHOICE.\n\nBug: 429\nChange-Id: I7011deadf518ddc344a56b07a0e268ceaae17fe0\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49347\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "28a59985d5e7fef04f32f7b13137efdf22cc1718", "old_mode": 33188, "old_path": "crypto/asn1/asn1_test.cc", "new_id": "d93e70467173f1b9bee1669b2a7ee4c55f549450", "new_mode": 33188, "new_path": "crypto/asn1/asn1_test.cc" }, { "type": "modify", "old_id": "51a860ded73ed570cd8e81341b2a6f132fb5e982", "old_mode": 33188, "old_path": "crypto/asn1/tasn_enc.c", "new_id": "6f35820f7058e36534ded548d2482d3ef4a19ab0", "new_mode": 33188, "new_path": "crypto/asn1/tasn_enc.c" } ] }