)]}'
{
  "commit": "217bfd3c96b04c6f1001924d202f4181a617ea6b",
  "tree": "e2c060cc4bf72aeb85e8ba285f0c03fc14adaa69",
  "parents": [
    "3474270abdebbd6235c1391e54aaba5924276666"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sat Sep 22 16:49:56 2018 -0500"
  },
  "committer": {
    "name": "Adam Langley",
    "email": "agl@google.com",
    "time": "Mon Oct 01 17:34:44 2018 +0000"
  },
  "message": "Fix undefined function pointer casts in IMPLEMENT_PEM_*.\n\nWhile it is okay to cast function pointers into different types for\ngeneric storage, the pointer must be cast back to the exact same type\nwhen calling. In particular, although C libraries do this sort of thing\nall the time, calling a T* d2i function as a void* d2i function is\nundefined:\n\n  If the function is defined with a type that is not compatible with the\n  type (of the expression) pointed to by the expression that denotes the\n  called function, the behavior is undefined\n\nFix some instances in the PEM/ASN1 wrapper functions. Synthesize helper\nfunctions instead.\n\nThis CL just addresses the function pointer issues. The inherited legacy\nOpenSSL ASN.1 code is still full other questionable data pointer dances\nthat will be much more difficult to excise. Continuing to exise that\ncode altogether (it is already unshipped from Cronet and unshipped from\nChrome but for WebRTC) is probably a better tack there.\n\nThis removes one (of many many) places where we require\n-fsanitize-cfi-icall-generalize-pointers.\n\nBug: chromium:785442\nChange-Id: Id8056ead6ef471f0fdf263bb50dc659da500e8ce\nReviewed-on: https://boringssl-review.googlesource.com/32105\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nReviewed-by: Adam Langley \u003calangley@gmail.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a43ca0de3628710a8ef9232abb1894d2c7d55b38",
      "old_mode": 33188,
      "old_path": "include/openssl/pem.h",
      "new_id": "9c0ff93cc4b000f9db3e8029ed28599b2fc18668",
      "new_mode": 33188,
      "new_path": "include/openssl/pem.h"
    }
  ]
}