commit 1db2156ce8cfc8fc247691e630dd8d85a3074f5d
author David Benjamin <davidben@chromium.org> Fri Dec 25 15:11:39 2015 -0500
committer Adam Langley <alangley@gmail.com> Fri Jan 15 20:15:55 2016 +0000
tree 3cc767e2f3f8350390ea52814b912e5edb292f3a
parent 96ba15fc69f73e2c5e2bd0a66e4bab05ee5d7c55

Move ssl3_record_sequence_update with the other record-layer bits.

Change-Id: I045a4d3e304872b8c97231dcde5bca7753a878fb
Reviewed-on: https://boringssl-review.googlesource.com/6831
Reviewed-by: Adam Langley <alangley@gmail.com>

ssl/tls_record.c

diff --git a/ssl/tls_record.c b/ssl/tls_record.c
index 3381eae..e3a413b 100644
--- a/ssl/tls_record.c
+++ b/ssl/tls_record.c
@@ -130,6 +130,18 @@
          SSL_CIPHER_is_block_cipher(ssl->aead_write_ctx->cipher);
 }
 
+int ssl_record_sequence_update(uint8_t *seq, size_t seq_len) {
+  size_t i;
+  for (i = seq_len - 1; i < seq_len; i--) {
+    ++seq[i];
+    if (seq[i] != 0) {
+      return 1;
+    }
+  }
+  OPENSSL_PUT_ERROR(SSL, ERR_R_OVERFLOW);
+  return 0;
+}
+
 size_t ssl_record_prefix_len(const SSL *ssl) {
   if (SSL_IS_DTLS(ssl)) {
     return DTLS1_RT_HEADER_LENGTH +
@@ -222,7 +234,7 @@
     *out_alert = SSL_AD_BAD_RECORD_MAC;
     return ssl_open_record_error;
   }
-  if (!ssl3_record_sequence_update(ssl->s3->read_sequence, 8)) {
+  if (!ssl_record_sequence_update(ssl->s3->read_sequence, 8)) {
     *out_alert = SSL_AD_INTERNAL_ERROR;
     return ssl_open_record_error;
   }
@@ -284,7 +296,7 @@
                          &ciphertext_len, max_out - SSL3_RT_HEADER_LENGTH,
                          type, wire_version, ssl->s3->write_sequence, in,
                          in_len) ||
-      !ssl3_record_sequence_update(ssl->s3->write_sequence, 8)) {
+      !ssl_record_sequence_update(ssl->s3->write_sequence, 8)) {
     return 0;
   }