commit 1d2c02bb8e9dbe84da24a2dae6ed57e867c02faa
author David Benjamin <davidben@google.com> Mon Apr 03 14:57:27 2017 -0400
committer Adam Langley <agl@google.com> Thu Apr 06 15:30:39 2017 +0000
tree b524466a2e0830598fff5a83836c653307c5cf9d
parent 69522117a6a16a568512821d18394c30aa4e6de6

SHA1_Init cannot fail.

This is the only single-shot hash function which pretends it has a
failure case.

Change-Id: Ibf45e197eafc63c368be3783dfeec8ccb95589ab
Reviewed-on: https://boringssl-review.googlesource.com/14584
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>

crypto/sha/sha1.c

diff --git a/crypto/sha/sha1.c b/crypto/sha/sha1.c
index 4eb8189..645d705 100644
--- a/crypto/sha/sha1.c
+++ b/crypto/sha/sha1.c
@@ -82,9 +82,7 @@
 
 uint8_t *SHA1(const uint8_t *data, size_t len, uint8_t *out) {
   SHA_CTX ctx;
-  if (!SHA1_Init(&ctx)) {
-    return NULL;
-  }
+  SHA1_Init(&ctx);
   SHA1_Update(&ctx, data, len);
   SHA1_Final(out, &ctx);
   OPENSSL_cleanse(&ctx, sizeof(ctx));