commit 1b22f85a5673ed5078737481231b4daa58a2b6f0
author David Benjamin <davidben@google.com> Thu Oct 27 16:36:32 2016 -0400
committer David Benjamin <davidben@google.com> Thu Oct 27 22:32:19 2016 +0000
tree 25747ad39096ad7d0f64f84ecc9e03210ae4f5b4
parent b6b6ff3bef673afaa4d05400564f8f4f4d31ad9c

Reject tickets from the future.

This shouldn't happen, but it is good to check to avoid the potential
underflow in ssl_session_is_time_valid.

This required tweaking the mock clock in bssl_shim to stop going back in
time.

Change-Id: Id3ab8755139e989190d0b53d4bf90fe1ac203022
Reviewed-on: https://boringssl-review.googlesource.com/11841
Reviewed-by: David Benjamin <davidben@google.com>

ssl/ssl_test.cc

diff --git a/ssl/ssl_test.cc b/ssl/ssl_test.cc
index 1c4ba7f..55ac923 100644
--- a/ssl/ssl_test.cc
+++ b/ssl/ssl_test.cc
@@ -2047,6 +2047,9 @@
   }
 
   for (uint16_t version : kTLSVersions) {
+    static const int kStartTime = 1000;
+    g_current_time.tv_sec = kStartTime;
+
     bssl::UniquePtr<SSL_CTX> server_ctx(SSL_CTX_new(TLS_method()));
     bssl::UniquePtr<SSL_CTX> client_ctx(SSL_CTX_new(TLS_method()));
     if (!server_ctx || !client_ctx ||
@@ -2088,6 +2091,15 @@
       fprintf(stderr, "Error resuming session (version = %04x).\n", version);
       return false;
     }
+
+    // Rewind the clock to before the session was minted.
+    g_current_time.tv_sec = kStartTime - 1;
+
+    if (!ExpectSessionReused(client_ctx.get(), server_ctx.get(), session.get(),
+                             false /* expect session not reused */)) {
+      fprintf(stderr, "Error resuming session (version = %04x).\n", version);
+      return false;
+    }
   }
 
   return true;