| commit | 0c8bc4653e34892dc291b48fb38e180ce92b5921 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Dec 25 22:52:22 2023 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 10 22:47:16 2024 +0000 |
| tree | a86b87c3febde9f2e498c0dad45b193d6973b443 | |
| parent | d62bd8ebd7f0e5eab1eb03197fd042094f7d0f45 [diff] |
Remove all -1 returns from X509_check_purpose Of external callers of this function, almost all are not actually doing anything with this operation and are just trying to trigger x509v3_cache_extensions. Triggering that is no longer necessarily now that the structure is opaque and accessors do it for you. There were three callers that wanted the actual operation here. One of them correctly handled the tri-state return, but did not distinguish 0 from -1. The other two did not and would misinterpret -1 as success! So this change is actually more compatible with OpenSSL callers than OpenSSL's actual behavior. Change-Id: Ifedba52dd9d4e031fc919276fd08ec22cfd33bf2 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65153 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: