commit 0aff3ffb8882a161de9550cc4ea8caacc713aadb
author David Benjamin <davidben@chromium.org> Mon Dec 07 13:17:03 2015 -0500
committer Adam Langley <agl@google.com> Wed Dec 16 19:59:29 2015 +0000
tree f8277b7c908d0ec7c79003e1d142570a906ea5d2
parent 5a19d7dfa8abe611da91d3b90f3313611bc9b3c4

Store the partial block as uint8_t, not uint32_t.

The uint32_t likely dates to them using HASH_LONG everywhere. Nothing ever
touches c->data as a uint32_t, only bytes. (Which makes sense seeing as it
stores the partial block.)

Change-Id: I634cb7f2b6306523aa663f8697b7dc92aa491320
Reviewed-on: https://boringssl-review.googlesource.com/6651
Reviewed-by: Adam Langley <agl@google.com>

include/openssl/md4.h

diff --git a/include/openssl/md4.h b/include/openssl/md4.h
index 19ed662..93c7af8 100644
--- a/include/openssl/md4.h
+++ b/include/openssl/md4.h
@@ -90,7 +90,7 @@
 struct md4_state_st {
   uint32_t h[4];
   uint32_t Nl, Nh;
-  uint32_t data[16];
+  uint8_t data[MD4_CBLOCK];
   unsigned num;
 };
 

include/openssl/md5.h

diff --git a/include/openssl/md5.h b/include/openssl/md5.h
index 055cdb0..55162f0 100644
--- a/include/openssl/md5.h
+++ b/include/openssl/md5.h
@@ -95,7 +95,7 @@
 struct md5_state_st {
   uint32_t h[4];
   uint32_t Nl, Nh;
-  uint32_t data[16];
+  uint8_t data[MD5_CBLOCK];
   unsigned num;
 };
 

include/openssl/sha.h

diff --git a/include/openssl/sha.h b/include/openssl/sha.h
index fec2927..48a52e8 100644
--- a/include/openssl/sha.h
+++ b/include/openssl/sha.h
@@ -115,7 +115,7 @@
   };
 #endif
   uint32_t Nl, Nh;
-  uint32_t data[16];
+  uint8_t data[SHA_CBLOCK];
   unsigned num;
 };
 
@@ -176,7 +176,7 @@
 struct sha256_state_st {
   uint32_t h[8];
   uint32_t Nl, Nh;
-  uint32_t data[16];
+  uint8_t data[SHA256_CBLOCK];
   unsigned num, md_len;
 };