)]}' { "commit": "03cae7a2b36285ddd6e7692964bb1b836d1d2572", "tree": "a41a5be6d68a84d0e235eb962dc8615ffb67799a", "parents": [ "dedd23e59237922d4e21673cd8044b59c48fe28e" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Fri Sep 24 12:25:41 2021 -0400" }, "committer": { "name": "Boringssl LUCI CQ", "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 24 17:18:39 2021 +0000" }, "message": "Keep EVP_CIPHER/EVP_MD lookup and do_all functions in sync\n\nNode seems uncommonly sensitive to this, so let\u0027s write these functions\nin a way that stays in sync and test this. See also\nhttps://boringssl-review.googlesource.com/c/boringssl/+/49585\n\nThis does incur a cost across all BoringSSL consumers that use these\nfunctions: as a result of Node indiscriminately exposing every cipher,\nwe end up pulling more and more ciphers into these getters. But that\nship sailed long ago, so, instead, document that EVP_get_cipherby*\nshould not be used by size-conscious callers.\n\nEVP_get_digestby* probably should have the same warning, but I\u0027ve left\nit alone for now because we don\u0027t quite have the same proliferation of\ndigests as ciphers. (Though there are things in there, like MD4, that\nought to be better disconnected.)\n\nChange-Id: I61ca406c146279bd05a52bed6c57200d1619c5da\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49625\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "786a5d5fb13d7ceafc9b7d58c0aaccb88552506d", "old_mode": 33188, "old_path": "crypto/cipher_extra/cipher_extra.c", "new_id": "62850ab6a216d401d023f81007fb59a33b4585f3", "new_mode": 33188, "new_path": "crypto/cipher_extra/cipher_extra.c" }, { "type": "modify", "old_id": "57fdc8ac1cbb588dbef7ad6f18e5b8319fc787f6", "old_mode": 33188, "old_path": "crypto/cipher_extra/cipher_test.cc", "new_id": "ad939e249bf35252eb7a269468e5c5ae0045ea25", "new_mode": 33188, "new_path": "crypto/cipher_extra/cipher_test.cc" }, { "type": "modify", "old_id": "ef95a6be0922aa92f90442150edaee8e04a42745", "old_mode": 33188, "old_path": "decrepit/CMakeLists.txt", "new_id": "16985da1996bab53a36f3262a3b096dc15200d29", "new_mode": 33188, "new_path": "decrepit/CMakeLists.txt" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "1f05ea5fa289ee117a0f27ca1bb54e37c2132db4", "new_mode": 33188, "new_path": "decrepit/evp/evp_test.cc" }, { "type": "modify", "old_id": "badd496293fb9748adacff10478ea702d1155c5f", "old_mode": 33188, "old_path": "include/openssl/cipher.h", "new_id": "09d72ec2c343f23409d35eca804a02e3290c86f1", "new_mode": 33188, "new_path": "include/openssl/cipher.h" } ] }