Convert stack.h to use inline functions.
Instead of a script which generates macros, emit static inlines in
individual header (or C files). This solves a few issues with the
original setup:
- The documentation was off. We match the documentation now.
- The stack macros did not check constness; see some of the fixes in
crypto/x509.
- Type errors did not look like usual type errors.
- Any type which participated in STACK_OF had to be made partially
public. This allows stack types to be defined an internal header or
even an individual file.
- One could not pass sk_FOO_free into something which expects a function
pointer.
Thanks to upstream's 411abf2dd37974a5baa54859c1abcd287b3c1181 for the
idea.
Change-Id: Ie5431390ccad761c17596b0e93941b0d7a68f904
Reviewed-on: https://boringssl-review.googlesource.com/16087
Reviewed-by: Adam Langley <agl@google.com>
diff --git a/include/openssl/pool.h b/include/openssl/pool.h
index dc5c938..8a07af5 100644
--- a/include/openssl/pool.h
+++ b/include/openssl/pool.h
@@ -17,6 +17,8 @@
#include <openssl/base.h>
+#include <openssl/stack.h>
+
#if defined(__cplusplus)
extern "C" {
#endif
@@ -29,6 +31,8 @@
* given blob to be kept in memory and referenced from multiple places. */
+DEFINE_STACK_OF(CRYPTO_BUFFER)
+
/* CRYPTO_BUFFER_POOL_new returns a freshly allocated |CRYPTO_BUFFER_POOL| or
* NULL on error. */
OPENSSL_EXPORT CRYPTO_BUFFER_POOL* CRYPTO_BUFFER_POOL_new(void);
