Move file_test_gtest.cc to CRYPTO_TEST_SOURCES for now
file_test_gtest.cc depends on GetTestData which, for now, only exists in
crypto_test because of how the crypto_test_data machinery works. Ideally
that would be fixed but, for now, move the file out of test_support.
Things were previously building because we were relying on the static
linker to drop the file in the other targets, before the linker would
notice the undefined symbol. I'm not sure what's different about
Chromium, but somehow Chromium is sensitive to this.
Bug: 542
Change-Id: I38c7719e7c3f27bcfeeab9693fcd43fbd0300799
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61526
Reviewed-by: Bob Beck <bbe@google.com>
Commit-Queue: Bob Beck <bbe@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
diff --git a/sources.cmake b/sources.cmake
index 8179d28..466ab49 100644
--- a/sources.cmake
+++ b/sources.cmake
@@ -66,6 +66,10 @@
crypto/stack/stack_test.cc
crypto/siphash/siphash_test.cc
crypto/thread_test.cc
+ # TODO(crbug.com/boringssl/542): This should be in TEST_SUPPORT_SOURCES, so
+ # that all tests can use it. But it depends on GetTestData, which is not
+ # currently usable outside of crypto_test.
+ crypto/test/file_test_gtest.cc
crypto/test/gtest_main.cc
crypto/trust_token/trust_token_test.cc
crypto/x509/x509_test.cc
@@ -421,7 +425,6 @@
crypto/test/abi_test.cc
crypto/test/file_test.cc
- crypto/test/file_test_gtest.cc
crypto/test/test_util.cc
crypto/test/wycheproof_util.cc
)
